'Favorite Tags' oblivious to multiple occurrences in nested tags

Bug reports for MicroDicom viewer
Post Reply
ymor
Posts: 5
Joined: Sun Jan 09, 2022 7:40 pm

'Favorite Tags' oblivious to multiple occurrences in nested tags

Post by ymor »

Kudos on implementing the very useful 'Favorite Tags' feature!

However, by displaying the value only of the FIRST OCCURRENCE found for a requested favorite tag, it incorrectly assumes that a tag is only present ONCE in a DICOM file -- which is not the case when a tag appears more than once, including NESTED occurrences inside one or more other tags.

For example, with a data file containing the following:

Code: Select all

(0008,1250)     Related Series Sequence	
   (FFFE,E000)  Item	
      (0020,000D)       Study Instance UID      2.25.85144150007758175394072630567553022354
      (0020,000E)       Series Instance UID     2.25.337519417599592786263903558250391822107
      (0040,A170)       Purpose Of Reference Code Sequence	
   (FFFE,E00D)  Item Delimitation Item
(FFFE,E0DD)     Sequence Delimitation Item

...

(0020,000D)     Study Instance UID      2.25.85144150007758175394072630567553022354
(0020,000E)     Series Instance UID     2.25.13560857619901190097814436205260939434
... if '(0020,000E) Series Instance UID' is chosen as a Favorite Tag,

then it will misleadingly show only the first instance found ("2.25.337519417599592786263903558250391822107", from inside the nested tag),without at least giving the user any indication that other instances also exist.

Perhaps the easiest way to fix this is to handle it in the same way that the 'All Tags' pane correctly displays MULTIPLE search results when searching, for example, for "Series Instance UID".

(Alternative solutions might involve the user specifying a specific nesting level and/or identifying specific "anchor" tags, but these are probably much more complicated.)
Attachments
nested-dicom-tags.zip
(227.24 KiB) Downloaded 9 times
microdicom
Site Admin
Posts: 401
Joined: Thu Jan 01, 1970 2:00 am
Location: Bulgaria
Contact:

Re: 'Favorite Tags' oblivious to multiple occurrences in nested tags

Post by microdicom »

We have missed it. Thank you for great finding. We will fix it soon.
ymor
Posts: 5
Joined: Sun Jan 09, 2022 7:40 pm

Re: 'Favorite Tags' oblivious to multiple occurrences in nested tags

Post by ymor »

microdicom wrote: Wed Jan 12, 2022 1:31 am We have missed it. Thank you for great finding. We will fix it soon.
Wonderful!

I'd like to refine my suggestion:

Even if you decide to implement the solution as originally suggested, in exactly the same way that the 'All Tags' pane correctly displays MULTIPLE search results when searching, for example, for "Series Instance UID" -- currently with a SINGLE line for each instance -- then at the very least you will have already eliminated the danger that the user will mistakenly think that he is seeing "the" value of this tag, by making it clear that there are indeed MULTIPLE values, some or all of which might be nested.

But it would ideal if, when finding a nested instance of a Favorite tag, that you also display the trail of enclosing tags, going all the way back up to the main level. For example:

Code: Select all

(0008,1250)     Related Series Sequence	
   (FFFE,E000)  Item	
      (0020,000E)       Series Instance UID     2.25.337519417599592786263903558250391822107

(0020,000E)     Series Instance UID     2.25.13560857619901190097814436205260939434
You might also want to do this for search results in the 'All Tags' pane.

Thanks again for implementing and perfecting this tremendously time-saving feature!
microdicom
Site Admin
Posts: 401
Joined: Thu Jan 01, 1970 2:00 am
Location: Bulgaria
Contact:

Re: 'Favorite Tags' oblivious to multiple occurrences in nested tags

Post by microdicom »

You can download the latest beta: https://www.microdicom.com/downloads/beta/
We fixed this issue. But the fix doesn't show enclosing tags. You will see it when you try it.
Please write us your feedback what do you think.

Thank you again for reporting this issue.
ymor
Posts: 5
Joined: Sun Jan 09, 2022 7:40 pm

Re: 'Favorite Tags' oblivious to multiple occurrences in nested tags

Post by ymor »

microdicom wrote: Wed Jan 19, 2022 2:54 pm You can download the latest beta: https://www.microdicom.com/downloads/beta/
We fixed this issue. But the fix doesn't show enclosing tags. You will see it when you try it.
Please write us your feedback what do you think.

Thank you again for reporting this issue.
First of all, thank you so much for implemented your fix for this so quickly.

I see that it indeed works (in the way that I originally suggested). And as I already mentioned, this is already a tremendous improvement, as it at least makes it clear to to the user that other instances of this tag exist, and that he/she needs to verify which exact instance corresponds to the specific value currently of interest.

MicroDicom-FixNestedTags-01.png
MicroDicom-FixNestedTags-01.png (603.66 KiB) Viewed 17 times

But, if possible, it would be very nice if you could "go the extra mile" and perfect this already-extremely-useful feature by also displaying the trail of enclosing tags, going all the way back up to the main level, as I subsequently suggested.

BTW: there seems to be a minor bug in the GUI; after starting the MicroDicom program, the "Patient Information," "All Tags," and "Favorite Tags" tab-labels at the bottom of the DICOM Tags pane are hidden, and not revealed until one hovers over them with the mouse or resizes the programs window.
Post Reply